Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EMCAL-630] Improve documentation of RawToCellConverterSpec #13060

Merged
merged 2 commits into from
Apr 22, 2024
Merged

[EMCAL-630] Improve documentation of RawToCellConverterSpec #13060

merged 2 commits into from
Apr 22, 2024

Conversation

mfasDa
Copy link
Collaborator

@mfasDa mfasDa commented Apr 22, 2024

  • Document functions which were missing a
    documentation so far
  • Add class documentation

@mfasDa
[EMCAL-630] Improve documentation of RawToCellConverterSpec
7344154 
- Document functions which were missing a
  documentation so far
- Add class documentation
@mfasDa mfasDa requested a review from jokonig as a code owner April 22, 2024 09:38
@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

jokonig
jokonig previously approved these changes Apr 22, 2024
View reviewed changes
@jokonig jokonig enabled auto-merge (rebase) April 22, 2024 09:41
@mfasDa
[EMCAL-911] Improve documentation of RecoContainer
86c4ab3 
- Fix headers of classes (particularly ingroup)
- Add class documentation
@mfasDa mfasDa disabled auto-merge April 22, 2024 11:07
@mfasDa mfasDa enabled auto-merge (rebase) April 22, 2024 11:08
@mfasDa mfasDa merged commit 9e505ea into AliceO2Group:dev Apr 22, 2024
13 checks passed
@mfasDa mfasDa deleted the EMCAL-630 branch April 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokonig jokonig jokonig approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mfasDa @jokonig