Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mult estimators to matching debug output #13064

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Add mult estimators to matching debug output #13064

merged 2 commits into from
Apr 23, 2024

Conversation

shahor02
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

davidrohr
davidrohr reviewed Apr 23, 2024
View reviewed changes
Detectors/GlobalTracking/src/MatchTPCITS.cxx Outdated
@@ -44,7 +44,9 @@
#include "DetectorsBase/GRPGeomHelper.h"
#include "ITStracking/IOUtils.h"

#include "GPUO2Interface.h" // Needed for propper settings in GPUParam.h
// #include "GPUO2Interface.h" // Needed for propper settings in GPUParam.h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this header? Does it create any problems? In principle, it is still needed to get the correct defines for GPUParam, etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I've commented it out when was fighting with compilation (missing param.inc) and then forgot to uncomment. But it works w/o it.

@davidrohr
Copy link
Collaborator

davidrohr commented Apr 23, 2024 via email

@shahor02
Copy link
Collaborator Author

CIs were green, just restorerd one include, merging

@shahor02 shahor02 merged commit f84b440 into AliceO2Group:dev Apr 23, 2024
6 checks passed
@shahor02 shahor02 deleted the pr_dbgmult branch April 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidrohr davidrohr davidrohr left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shahor02 @davidrohr