-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPL Analysis: provide metadata to workflow construction #13130
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Very nice! :-) |
Tested locally with the simple test and indeed it now does not load ROOT once it finds out the options and injects them in the topology. Now testing on hyperloop. |
d500f5b
to
38f76e0
Compare
Error while checking build/O2/fullCI for 38f76e0 at 2024-05-15 16:33:
Full log here. |
26ad8f3
to
1bb68dd
Compare
This version seems to behave on hyperloop as well. Will merge if the tests pass. |
Merging this. Works on hyperloop and it should not have any effect if the metadata is not used. Moreover, changing one line (the list of capability plugins) should be enough to completely disable the new behavior. |
Why the change from |
Hi everyone, let me also support @mhemmer-cern 's question... this is quite a complicated change because - at least at my workplace - quite a few people lost quite some time to figure out that this had happened (and in fact nobody replied to my message in the analysis channel :-( )... |
On Hyperloop, we still use aod-file. We didn't change anything. This private must have some internal reason and it is a hack to use it externally. But I let Giulio comment... |
Hey @jgrosseo thanks for the reply. So the problem that I faced with this change is for local testing, which should affect pretty much everyone for local testing, since our json config files had |
Hi @jgrosseo my guess is you dodged that because the |
@mhemmer-cern We do not use |
indeed, the private you should ignore, why is it an issue? Can you point me to the a reproducer which breaks? |
Hey @ktf, |
While I cannot comment on how this private script itself works, I suspect what is happening here is indeed what @jgrosseo suggested. If the config gets cached across different releases there is no guarantee that will actually work: it might, it might not or it might silently misbehave. This is in particular true for workflow options like My recommendation would be to change your script to always generate the config from scratch when switching releases. If you point me to the actual script I can probably be more precise. That said, for this specific case I think I can now get rid of the |
DPL Analysis: provide metadata to workflow construction