Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First version of pedestal calibration workflow raw data -> ccdb #5036

Merged
merged 8 commits into from Dec 14, 2020
Merged

First version of pedestal calibration workflow raw data -> ccdb #5036

merged 8 commits into from Dec 14, 2020

Conversation

wiechula
Copy link
Collaborator

@wiechula wiechula commented Dec 9, 2020

Includes

  • modification of pedestal calibration workflow, allowing for sending data to ccdb
  • modification of raw -> digits -> tracking, not fully working yet
  • modularization of raw data decoding in workflows
  • extension of raw data decoder to dump sync event position
  • extension of raw data decoder to dump raw data per GBT link

@wiechula wiechula force-pushed the RawReaderCRU branch 2 times, most recently from 312d890 to d933a27 Compare December 14, 2020 09:36
@wiechula
Add function to dumpGBT data per link
f1a8311
@wiechula
fix meta data entry
d435c7f
@wiechula
Add median per stack, alias for edge pad
c7fb3ab
@wiechula
rework pedestal calibration
a0e296e 
o move calibratoin workflow from calibration to workflow
o Change to task for easier handling
o Add more processing options
o Add sending of calibration data to be able to store them in CCDB
@wiechula
Code splitting and cleanup
99acfb0 
o move common raw data processing function for calibrations to separate
file
o clean up includes
@wiechula
rework RawToDigitsSpec
7ea80e7
@wiechula
Add possibility to dump sync positions to file
26085ba
@wiechula
Add switch to skip incomplete events, by default process all
19fec6e
@wiechula
Copy link
Collaborator Author

@shahor02 , @davidrohr , could you have a look if this can be merged? I fail to understand the problem in the failed tests. The only thing I see is something in CMake which doesn't seem to be related to my commits.

@shahor02
Copy link
Collaborator

Hi @wiechula
The CMake "Manually-specified variables were not used by the project" warning is produced everywhere, so the o2 and o2-dataflow failures are not related to your PR. I would wait for fullCl then merge. Shall I squash the PR?

@wiechula
Copy link
Collaborator Author

Hi @shahor02 , thanks! The commits are only partly related, so I would prefer not to squash if possible.

shahor02
shahor02 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures unrelated, merging

@shahor02 shahor02 merged commit bafe874 into AliceO2Group:dev Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahor02 shahor02 shahor02 approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wiechula @shahor02