Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TrackPar(Cov) compatible to GPU #5043

Merged
merged 9 commits into from Dec 12, 2020

Conversation

davidrohr
Copy link
Collaborator

@mconcas : This is my current state. It still fails compilation on HIP, but that should not bother your. Let's see if this passes the CI without AMD.
It is so far only TrackPar and TrackParCov, the Propagator will come next.
But I didn't test it yet, just compiled it with CUDA in Standalone mode, will become more mature the next days.

In order to use it:
The TPC GPU code works a bit differently compared to what you do in ITS. There is no separate compilation, but all files are included in the CU files. If you want to keep going with separate compilation, that should not be a problem. Just create a CU file that includes TrackParametrization.cxx and TrackParametrizationWithErrors.cxx (and later the propagator) and link that together with whatever code you write in your library. Symbols should not collide in theory. Let's see :)

@mconcas
Copy link
Collaborator

mconcas commented Dec 9, 2020

Thank you very much, looking forward to test it.

@davidrohr davidrohr force-pushed the dev_pull_request2 branch 2 times, most recently from 53a4c54 to 024170a Compare December 11, 2020 20:43
@davidrohr davidrohr changed the title [DON'T MERGE YET] Make TrackPar(Cov) compatible to GPU Make TrackPar(Cov) compatible to GPU Dec 11, 2020
@davidrohr
Copy link
Collaborator Author

@mconcas : FYI: the problems with HIP are solved now. I still need to work on the propagator and then integrate it for the TPC refit, but at least the commits so far should not have side effects, and I'll merge this once the CI passes to have this part in already to have some stable basis to work on and to avoid merge conflicts.

@davidrohr davidrohr merged commit 73c10d5 into AliceO2Group:dev Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants