New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][ITS-tracking] Add track dumping in standalone debugger #5069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mconcas !
Please see a few comments below.
occurrences.clear(); | ||
for (size_t iCluster{0}; iCluster < 7; ++iCluster) { | ||
int extIndex = track.getClusterIndex(iCluster); | ||
o2::MCCompLabel mcLabel = event.getClusterLabels(iCluster, extIndex); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in principle, a cluster may have multiple labels. What is the reason to copy the labels into the ROframe, rather than fetching them by cluster index from the MC container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I just got this from the approach used in the tracker to access the labels, at some point I realised it is a duplication.
Unless I am forgetting some strong reason we might consider to simplify this, will check with Max to be sure.
Detectors/ITSMFT/ITS/tracking/include/ITStracking/StandaloneDebugger.h
Outdated
Show resolved
Hide resolved
Hi @shahor02,
Please if you have some suggestion on how make this utility more handy it is very welcome. Cheers, |
@mconcas thanks! Indeed, for (2) what matters are the clusters (position, errors) as used in the Tracker::fitTrack. |
Well, then using our clusters is even more consistent. I'll let it as it is. |
Are you sure? Now you are extracting the clusters from the PrimaryVertexContext (as far as I can see, they provide lab coordinates) while for the fit you take them as |
You are right, we actually use both (clusters for track seed initialisation and trackingFrameInfo for fit and propagation). |
a1a4504
to
866ba39
Compare
Hi @shahor02 , if this can work for you I have nothing more to put here at this iteration. Cheers |
Hi @shahor02,
this pr adds the possibility to dump a
o2::its::TrackITSExt
on file.By enabling
CA_DEBUG
inDefinitions.h
it creates automatically the file. I tested with the macro, should work also on workflow.I also have a previously developed
FakeTrackInfo
class that performs some checks on the labels given a track to decide whether it is fake and other details.My goal is to stream also this struct on file, coupled to the actual track.
This last class still does not work for some reason, tomorrow I'll fix it. In the meanwhile if you want to have a look, the track dumping works (i randomly put it in some point in the code, for today).
Cheers