Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFT: fix lanes mapping for decoding commissionning data and for worki… #5088

Merged
merged 1 commit into from Dec 19, 2020

Conversation

bovulpes
Copy link
Collaborator

@bovulpes bovulpes commented Dec 18, 2020

…ng also with MC, both MFT and ITS

with minimum invasion in the common code and the ITS code:

  • in MC2RawEncoder treat the loop index "icab" as mapping index "cablePos" (dummy identity in case of ITS)

  • introduce the cable position for the "lanes" word which is given by the HW ID in the case of MFT

  • consequently, the RU cable data array is filled with gaps in the case of the MFT

I have checked it for MC encoding/decoding ITS and MFT.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures seem to be false-positive.
For the ITS the changes are neutral, merging

@shahor02 shahor02 merged commit 7431594 into AliceO2Group:dev Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants