New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGHF: fix of the histogram registry in the Lc task #5150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrosseo
requested changes
Jan 12, 2021
jgrosseo
previously approved these changes
Jan 12, 2021
jgrosseo
changed the title
PWHF: fix of the histogram registry in the Lc task
PWGHF: fix of the histogram registry in the Lc task
Jan 12, 2021
jgrosseo
previously approved these changes
Jan 13, 2021
vkucera
requested changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tab in front of continue;}*/
on line 67 in taskLc.cxx
(and other tabs if any).
vkucera
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me.
This was referenced Jan 15, 2021
ginnocen
approved these changes
Jan 16, 2021
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
Co-authored-by: Luigi <ldellost@aliceml.cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of the histogram registry in the Lc task in agreement with the pull request: https://github.com/AliceO2Group/AliceO2/pull/5050/files
Fixing histograms and binning in the Lc task accordingly to the AliPhysics task.