GPU: Add option to tpc-reco-workflow to ship shared cluster map created during tracking #5186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidrohr thanks, I will adopt this in the matching code. Could you make this output ON by default whenever the clusters output is requested? |
…ed during tracking
davidrohr
force-pushed
the
dev_pull_request
branch
from
9be0e5b
to
bac1b41
Compare
|
@shahor02 : I have inverted the argument, so no it is enabled by default but it can be disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shahor02 : This adds the option to the tpc-reco-workflow to shop also the shared cluster map, just add shared-cluster-map to the output type. It is not stored to a ROOT file, I assume compared to ROOT IO the recreation is pretty much irrelevant. It will ship as datatype
TPCCLSHAREDMAPand just a a plain char array. I checked the correctness of the map before shipping, didn't yet try to receive it but I don't see how I could have messed up the sending part ... :)Do you want to adapt the its/tpc matching workflow, or shall I have a look?