Fixed memory leak in DataContainer3D #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
sawenzel
reviewed
Jan 18, 2021
| @@ -144,6 +144,7 @@ bool DataContainer3D<DataT, Nx, Ny, Nz>::initFromFile(TFile& inpf, const char* n | |||
| return false; | |||
| } | |||
| mData = dataCont->mData; | |||
| delete dataCont; | |||
There was a problem hiding this comment.
I think the same should be done a few lines further down?
There was a problem hiding this comment.
You mean the loadFromFile() function? There the pointer is just returned and I think shouldnt be deleted? But since this function is actually never used in any of the SpaceCharge classes, it might be better to just remove the function and keep the class more simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.