Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableMaker task updated to use configurables for system type, event and track selections #5206

Merged
merged 5 commits into from Jan 19, 2021

Conversation

iarsene
Copy link
Collaborator

@iarsene iarsene commented Jan 17, 2021

TableMaker:

  1. Event and track selections can be specified via configurables selecting predefined cuts in the CutsLibrary.
  2. A special configurable for the minimum pt of the lepton is added to allow switching between the quarkonia and lmee analyses.
  3. The task can now be run on either pp or PbPb by specifying the isPbPb parameter. In the case of pp, the centrality task has to be taken out from the pipe.
  4. Histogram definition is now using the predefined histogram groups from the HistogramLibrary. Configurables should be added in the future to control the level of histogramming detail.

Ionut Arsene added 2 commits January 17, 2021 17:13
    The task can also run now on both pp and PbPb data, by specifying the isPbPb bool parameter
@jgrosseo
Copy link
Collaborator

Could the list of runs come from a CCDB object? Everything should be ready to do that already. You can check out the "globalEfficiency" tutorial.

@iarsene
Copy link
Collaborator Author

iarsene commented Jan 18, 2021

In principle yes, if these run lists exist already then one can save having all the lists added manually in the utility function. I think this would be nice to interface with what the DPG will provide at some point.

Copy link
Collaborator

@jgrosseo jgrosseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As just discussed on mattermost, the hard coded run lists should be moved to CCDB. A better solution needs further discussion...

@iarsene iarsene marked this pull request as draft January 18, 2021 15:27
@iarsene iarsene marked this pull request as ready for review January 18, 2021 20:22
@iarsene iarsene merged commit 54506d2 into AliceO2Group:dev Jan 19, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
…nd track selections (AliceO2Group#5206)

* TableMaker task updated to use configurables for event and track cuts.
    The task can also run now on both pp and PbPb data, by specifying the isPbPb bool parameter

* fixed missing braces for the fullCI test

* clang fix

* removed predefined run lists from HistogramsLibrary

Co-authored-by: Ionut Arsene <iarsene@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants