Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGHF: Adding flag selection in the hadron tasks #5218

Merged
merged 1 commit into from Jan 20, 2021

Conversation

DelloStritto
Copy link
Contributor

No description provided.

@DelloStritto DelloStritto marked this pull request as ready for review January 18, 2021 13:03
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, it works by sheer luck.
There is currently no correspondence between the hfflag() values set in the index skimming and the DecayType values used in MC matching.
@nzardosh I suggest to use the DecayType values for the skimming bits as well.
Same applies to #5204.

@nzardosh
Copy link
Contributor

If this works, it works by sheer luck.
There is currently no correspondence between the hfflag() values set in the index skimming and the DecayType values used in MC matching.
@nzardosh I suggest to use the DecayType values for the skimming bits as well.
Same applies to #5204.

Hi @vkucera , yes I agree. This was the idea behind Luigi's change too.

@@ -155,7 +155,8 @@ DECLARE_SOA_COLUMN(FlagMCMatchRec, flagMCMatchRec, int8_t); // reconstruction le
DECLARE_SOA_COLUMN(FlagMCMatchGen, flagMCMatchGen, int8_t); // generator level

// mapping of decay types
enum DecayType { D0ToPiK = 1 };
enum DecayType { D0ToPiK = 0,
JPsiToEE };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> JpsiToEE

@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2021

I suppose the same bit check should be added in the rec. part of the MC tasks as well, right?

@DelloStritto
Copy link
Contributor Author

DelloStritto commented Jan 19, 2021

I suppose the same bit check should be added in the rec. part of the MC tasks as well, right?

I think it is not strictly needed because we check the bit here:
https://github.com/AliceO2Group/AliceO2/blob/dev/Analysis/Tasks/PWGHF/taskLc.cxx#L127

@vkucera
Copy link
Collaborator

vkucera commented Jan 19, 2021

I suppose the same bit check should be added in the rec. part of the MC tasks as well, right?

I think it is not strictly needed because we check the bit here:
https://github.com/AliceO2Group/AliceO2/blob/dev/Analysis/Tasks/PWGHF/taskLc.cxx#L127

But maybe we can add it so we do not loop over all the candidates.

I think it is needed if we want to fill the MC background histograms with the same candidates that populate the combinatorial background in the non-MC task. Isn't it?

@DelloStritto
Copy link
Contributor Author

DelloStritto commented Jan 19, 2021

I suppose the same bit check should be added in the rec. part of the MC tasks as well, right?

I think it is not strictly needed because we check the bit here:
https://github.com/AliceO2Group/AliceO2/blob/dev/Analysis/Tasks/PWGHF/taskLc.cxx#L127
But maybe we can add it so we do not loop over all the candidates.

I think it is needed if we want to fill the MC background histograms with the same candidates that populate the combinatorial background in the non-MC task. Isn't it?

I'm not sure about this. In this way we would not compute the loss in efficiency due to the skimming cuts and I'm not sure this is what we want.

I missed that you specified "rec part of the MC" in your comment. I think that you are right

@iarsene
Copy link
Collaborator

iarsene commented Jan 20, 2021

Hi, is this PR ready now ?

@ginnocen
Copy link
Collaborator

@iarsene, please wait. We have to make a few extra tests.

@iarsene
Copy link
Collaborator

iarsene commented Jan 20, 2021

Maybe switch to draft so we avoid mistakenly merging these PRs

@iarsene iarsene merged commit d5f8673 into AliceO2Group:dev Jan 20, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Co-authored-by: Luigi <ldellost@aliceml.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants