New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGHF: Adding flag selection in the hadron tasks #5218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkucera , yes I agree. This was the idea behind Luigi's change too. |
d2959e1
to
7ccd1cb
Compare
@@ -155,7 +155,8 @@ DECLARE_SOA_COLUMN(FlagMCMatchRec, flagMCMatchRec, int8_t); // reconstruction le | |||
DECLARE_SOA_COLUMN(FlagMCMatchGen, flagMCMatchGen, int8_t); // generator level | |||
|
|||
// mapping of decay types | |||
enum DecayType { D0ToPiK = 1 }; | |||
enum DecayType { D0ToPiK = 0, | |||
JPsiToEE }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-> JpsiToEE
I suppose the same bit check should be added in the rec. part of the MC tasks as well, right? |
I think it is not strictly needed because we check the bit here: |
I think it is needed if we want to fill the MC background histograms with the same candidates that populate the combinatorial background in the non-MC task. Isn't it? |
I'm not sure about this. In this way we would not compute the loss in efficiency due to the skimming cuts and I'm not sure this is what we want. I missed that you specified "rec part of the MC" in your comment. I think that you are right |
Hi, is this PR ready now ? |
@iarsene, please wait. We have to make a few extra tests. |
Maybe switch to draft so we avoid mistakenly merging these PRs |
Co-authored-by: Luigi <ldellost@aliceml.cern.ch>
No description provided.