refactor TRD digit class #5221
refactor TRD digit class #5221
Conversation
bazinski
commented
Jan 18, 2021
bazinski
commented
- Convert digits to store rob/mcm and not pad/row.
- The interface for pad row remains so code wont change.
- For shared pads the lower indexed mcm is returned. It is the users responsibility to check if its shared if needed for their purposes.
- The plan was to move digit to DataFormats, but there is a circular library, so postponed to later.
bazinski
force-pushed
the
changedigits
branch
from
724d202
to
8cb4252
Compare
bazinski
force-pushed
the
changedigits
branch
2 times, most recently
from
8996a79
to
d51dbeb
Compare
|
@shahor02 shot for seeing, now fixed. |
bazinski
force-pushed
the
changedigits
branch
from
53deaae
to
58692a2
Compare
| void setROB(int row, int pad) { mROB = FeeParam::getROBfromPad(row, pad); } | ||
| void setMCM(int mcm) { mMCM = mcm; } | ||
| void setMCM(int row, int pad) { mMCM = FeeParam::getMCMfromPad(row, pad); } | ||
| void setChannel(int channel) { mChannel = channel; } |
There was a problem hiding this comment.
Are these setters actually used? I would expect that we always know at construction which pad these digits refer to.
There was a problem hiding this comment.
I prefer keeping them for completeness; they are harmless.
|
@tdietel let me change the rob value to uint8_t that will have somewhat of an impact on the sizing of the output, assuming it does not get padded. |
|
@tdietel regarding the set methods, i dont use them, they are simply there for completeness. |
bazinski
force-pushed
the
changedigits
branch
from
29112a6
to
62a7c80
Compare
It will be padded |
|
@shahor02 when you get a chance could you approve the change as per your request and merge? |
