Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing TPC split task in CMakeFile #5238

Merged
merged 1 commit into from Jan 20, 2021
Merged

Fix missing TPC split task in CMakeFile #5238

merged 1 commit into from Jan 20, 2021

Conversation

njacazio
Copy link
Contributor

  • Replace spectraTPC.cxx with spectraTPC_split in CmakeFile
  • Uniform pid and spectra tasks
  • Remove QA from split and tiny tasks
  • Use common nomenclature pid and spectra tasks

@njacazio
Fix missing TPC split task in CMakeFile
ceeb4c6 
- Replace spectraTPC.cxx with spectraTPC_split in CmakeFile
- Uniform pid and spectra tasks
- Remove QA from split and tiny tasks
- Use common nomenclature pid and spectra tasks
@njacazio
Copy link
Contributor Author

njacazio commented Jan 20, 2021 •
edited

@jgrosseo this should fix the issue for the split TPC PID task.
The issue was here: https://github.com/AliceO2Group/AliceO2/pull/5238/files#diff-d252f47538976876cc9a6bbcc6284d0ff18fd87747f6d2e931c215d38dfad84aL57
Also, I set to ON all PID information in all tasks so as to have everything ready for hyperloop.
I also simplified the producer and user tasks, I removed the QA tasks from the PID response ones, we could probably move the PID QA to a separate file in the future.

@jgrosseo jgrosseo merged commit 7e284ee into AliceO2Group:dev Jan 20, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
@njacazio @jgrosseo
Fix missing TPC split task in CMakeFile (AliceO2Group#5238)
ac825ca 
- Replace spectraTPC.cxx with spectraTPC_split in CmakeFile
- Uniform pid and spectra tasks
- Remove QA from split and tiny tasks
- Use common nomenclature pid and spectra tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

@iarsene iarsene Awaiting requested review from iarsene

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@njacazio @jgrosseo