Fix Z position of ML/OL modules to be symmetric wrt half stave center #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iouribelikov @shahor02 this is the PR for the fix on the modules position. |
shahor02
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the geometry description of the ML/OL ITS staves was first developed, the stave length was computed from the dimensions of the modules. Later when the stave length was fixed as a parameter, based on the blueprints, the positioning of the modules was not updated correctly, resulting in a bug for which the modules were no more symmetrically placed wrt the center of the stave (i.e. the first module was aligned to the edge of the stave).
The proposed patch fixes this bug so as to have the modules properly placed along the stave.