New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file reader for TPC Tracks and Clusters (+ MC info) #5256
Conversation
@tklemenz : I think it might be helpful to add the option to distribute both clusters and tracks. |
Hi @davidrohr, I agree, this might be useful. I will look into it. Until now I only tested the file reader with the "old" QC workflows but I will check with your new one and let you know. |
Thx, I think this is important in particular for the MC labels, since I believe they are not used in the other tasks. The instructions are in this JIRA ticket: https://alice.its.cern.ch/jira/browse/QC-519?filter=-2 |
@davidrohr, I checked with your TrackingQA and it ran without issues. When I do When the reading of clusters and tracks at the same time works, I will update the PR. I ran the test above calling the file reader twice. @shahor02, I will remove the mentioned customization and the dispatching-mode and add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tklemenz : Thx, the output on the qcg page looks OK. Those efficiency histograms are empty in the mergeable output. They would only be filled when the postprocessing runs. I guess I should remove them completely when the output is set to mergeable.
I am thinking how to make the reader read two files at a time. My problem is, that the A dirty workaround is to add the option Do you have an idea maybe? |
@tklemenz it should work with --infile for both readers, provided you put each of them in quotes, i.e.
|
Yes! Thanks a lot, this works. I will push the changes asap. |
enum struct Input { Clusters, | ||
Tracks | ||
}; | ||
|
||
const std::unordered_map<std::string, Input> InputMap{ | ||
{"clusters", Input::Clusters}, | ||
{"tracks", Input::Tracks}}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not necessarily need to be there. I could also include the RecoWorkflow header and use the OutputType
enum from there instead and adjust the InputMap
but I think this is the nicer solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok, it is not so much code... :)
When you are ready, can you remove the WIP such that the CI runs, or is there still something to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tklemenz could you remove [WIP] to trigger the CI tests?
I rebased on the latest dev branch and removed WIP. |
This adds a file reader workflow to read either tracks (with or without MC info) or clusters (with or without MC info) from file and provides them in the DPL.
o2-tpc-file-reader --infile tpctracks.root --input-type tracks
o2-tpc-file-reader --infile tpc-native-clusters.root --input-type clusters