Add option to create an o2 propagator instance uninitialized to be used with external matLut / gpuFieldMap #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed with external matLut / gpuFieldMap
|
@davidrohr : should be ok, I was anyway considering to remove the initialization from the c-tor, and suppress the request for the geometry loaded. |
shahor02
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shahor02 : Is this ok for you?
It is a bit ugly, since if someone else requires an initialized propagator later, he won't get it.
On the other hand, 2 users requesting the propagator share the same instance anyway, and if one alter the settings, that affects the other user as well, so I think my patch does not introduce an additionall problem.