Fixes in MCCompLabel, cleanup of redundant labels in matching #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
bovulpes,
iouribelikov and
sawenzel
as code owners
sawenzel
previously approved these changes
Feb 3, 2021
|
Looks good to me. Ok to merge when last compile errors solved. |
added 2 commits
February 3, 2021 09:14
Cast operator was interfering with more useful comparison operator, is getRawValue instead of cast. Added relation operators since some detector need the MC labels to be sortable
Both ITS-TPC and XXX-TOF (with XXX either TPC or ITS-TPC) matching were producing the vector of label for match constituents. Now only the label for the match is produced. The conventions are: ITS-TPC => label takes the TPC label (source, event, trackID) and is declared fake if ITS_label != TPC_label XXX-TOF => label takes the TOF label (source, event, trackID) and is declared fake if TOF_label != XXX_label The isFake flag of constituents are ignored in the comparison
davidrohr
approved these changes
Feb 3, 2021
|
@ktf @TimoWilken the o2-dataflow CI reports the error from the log of previous failed test: the PR was updated at ~9:30 while the log with error shows |
|
@shahor02 that's because the build fails without producing logs to overwrite the old ones, so the old ones get uploaded again... I've cleaned up the build and reset it, hopefully it'll work this time. |
shahor02
pushed a commit
to shahor02/AliceO2
that referenced
this pull request
Feb 4, 2021
This is to amend AliceO2Group#5366 Suppression of standalone track lables in the output of barrel matched tracks was not propagated everywhere
shahor02
pushed a commit
that referenced
this pull request
Feb 4, 2021
This is to amend #5366 Suppression of standalone track lables in the output of barrel matched tracks was not propagated everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.