Splitting IO and wait time in metrics #5368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ktf The clang check failed and your usual nice PR which fixes clang does not work anymore :-( |
|
? I see it green? @TimoWilken did anything change? |
|
@ktf Yes, I then fixed clang myself |
|
The error in the clang-format checker happens because it tries to push the cleanup branch to alibuild's fork, which is "1396 commits behind" this repo. Some of those commits change workflows, but alibuild can't push those commits to its own repo without the workflow permission. @ktf I suggest the clang-format checker gets the workflow permission, so it can make PRs again. |
|
@ktf btw. are you fine with the changes itself? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.