Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from string to seconds #5386

Merged
merged 1 commit into from Feb 8, 2021

Conversation

chiarazampolli
Copy link
Collaborator

For some reason, libstdc seems to have issues parsing the month
("%b" option), so now I use the SQL format.

For some reason, libstdc seems to have issues parsing the month
("%b" option), so now I use the SQL format.
@chiarazampolli chiarazampolli requested review from noferini and a team as code owners February 5, 2021 00:12
@chiarazampolli
Copy link
Collaborator Author

@aphecetche , FYI.

@chiarazampolli
Copy link
Collaborator Author

The error in the CI seem unrelated, concerning:
o2-test-framework-SimpleRDataFrameProcessing
o2-test-framework-ParallelPipeline
o2-test-framework-Forwarding
...
Am I wrong? Is there something related to this change too?

@chiarazampolli
Copy link
Collaborator Author

Hello,

This should be a trivial change, no idea why the CI fails. Can someone check?

Cheers,

Chiara

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failures are not related to this PR, merging

@shahor02 shahor02 merged commit 042639a into AliceO2Group:dev Feb 8, 2021
@davidrohr
Copy link
Collaborator

The CI is currently generally broken, with several issues. I have been looking at it during the weekend a bit.
@ktf @TimoWilken @MichaelLettrich : We should try to return to a working state ASAP.
Issues I have been seeing are:

  • MacOS always fails with dyld: Library not loaded: /System/Volumes/Data/build/ci_checks/alice_ci_0/o2/sw/INSTALLROOT/9ac921ecfd5f7c7ec35229b571fb57eb2d3d5618/osx_x86-64/fastjet/v3.3.3_1.042-alice1-4/lib/libfastjettools.0.dylib
  • O2/o2 sometimes suceeds, but usually just fails without leaving a log.
  • Full CI fails (almost) always with one of the following 3 issues:
    • O2 Compilation Failure when the workflow JSONs are dumped: [ERROR] Unhandled o2::framework::runtime_error reached the top of main, device shutting down. Details follow:
    • DataFormats/MemoryResources/test/testMemoryResources.cxx fails the test (almost) always.
    • Other ctests are failing randomly.
      (my feeling is that these failures are since the introduction of the websocket communication in DPL.)

@chiarazampolli
Copy link
Collaborator Author

Thanks @davidrohr (I indeed thought something is broken), and @shahor02 !

Chiara

@chiarazampolli chiarazampolli deleted the fixTimeConversion branch May 16, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants