Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGHF: Change the eta cut with the Y cut in the tasks #5393

Merged
merged 1 commit into from Feb 10, 2021

Conversation

DelloStritto
Copy link
Contributor

@DelloStritto DelloStritto commented Feb 5, 2021

  • Apply the usual Rapidity (Y) cut on the candidate insted of the eta cut.
  • The pull request will be followed up by another one on the validation task to updated the old "cutEtaCandMax" cut in the json files.

To be merged together with:
AliceO2Group/Run3Analysisvalidation#157

vkucera
vkucera previously approved these changes Feb 9, 2021
Copy link
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @ginnocen

@ginnocen ginnocen changed the title PWGHF, DO NOT MERGE: Change the eta cut with the Y cut in the tasks PWGHF: Change the eta cut with the Y cut in the tasks Feb 9, 2021
Copy link
Collaborator

@ginnocen ginnocen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DelloStritto this looks good to me. Can you propagate it to the other tasks? so that we make a single commit?

@DelloStritto
Copy link
Contributor Author

DelloStritto commented Feb 9, 2021

@DelloStritto this looks good to me. Can you propagate it to the other tasks? so that we make a single commit?

Yes, of course. Only for the J/Psi I think that Biao already propagated the modification by himself.

@ginnocen
Copy link
Collaborator

ginnocen commented Feb 9, 2021

Yoda, this looks good to me. @vkucera

@ginnocen ginnocen merged commit 1f5cc84 into AliceO2Group:dev Feb 10, 2021
EmilGorm pushed a commit to EmilGorm/AliceO2 that referenced this pull request Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants