Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: unify JSON representation of arrays in Variant #5417

Merged

Conversation

aalkin
Copy link
Member

@aalkin aalkin commented Feb 9, 2021

@jgrosseo this adds an extra "values" layer in JSON representation of 1d and 2d arrays, consistent with labeled arrays.

@aalkin aalkin requested a review from a team as a code owner February 9, 2021 09:56
@jgrosseo
Copy link
Collaborator

jgrosseo commented Feb 9, 2021

@TimoWilken @ktf @davidrohr Do we know what is going on with the CI? The failures here some to be unrelated (and there are other PRs where everything is red as well)...

@davidrohr
Copy link
Collaborator

@jgrosseo : At the moment they are all almost always failing. I'd try not to force-merge too much, since that would be basically untested (the fact that it fails for an unrelated reason does unfortunately not imply that it should succeed on a PR...).
@TimoWilken is working on the issue with macOS and o2, which seem to be related. I am not sure if that will also fix the full CI. I believe the full CI problem appeared after the websocket commit in DPL. @ktf has claimed to fix it yesterday evening. I am currently checking his fix in my full-system test. But the full CI is still failing. So either this is yet another unrelated issue, or the websocket fix is still insufficient...

@jgrosseo jgrosseo merged commit 4f849b1 into AliceO2Group:dev Feb 11, 2021
@aalkin aalkin deleted the unify-json-representation-for-arrays branch May 30, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants