TRD trigger records for raw data input and trigger record bug fix #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarrella
requested review from
bazinski,
jolopezl,
martenole and
tdietel
as code owners
jbarrella
force-pushed
the
digit-converter-update
branch
from
fe9213a
to
d6584b7
Compare
tdietel
approved these changes
Feb 10, 2021
There was a problem hiding this comment.
Looks ok to me.
@bazinski, I think the TRAP simulator should also run without MC labels. To be fixed at some point... Do we have a place where we keep track of these things? Once this is done, we can remove the MC labels from this macro.
|
is this ready to be merged? |
bazinski
approved these changes
Feb 11, 2021
|
@shahor02 yes I think so. |
jolopezl
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds trigger record to digits converted from raw data input. Also fixes a bug in trigger record creation where the trigger recorded was updated at the level of the detector loop rather than the event loop.
Patch also includes some changes from @martenole who added a dummy MC labels branch to the output for compatibility with TRAPsim.