New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU: Add SMatrixGPU and Fwd decls #5425
Conversation
@davidrohr I set up a possible implementation, did I get correctly the approach? |
05dd550
to
14f80df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you want to do more tests, or shall I merge?
It actually looks like we have an issue with OpenCL or it is something unrelated? |
Argh, indeed, I hadn't checked the CI yet :( |
Yes, I can for sure. Just to understand whether it will be required some changes on the code in near future. Thanks, setting up the workaround in the meanwhile... |
Yes, clang has this extension for function pointers (although it does not work with all types of function pointers, but I guess yours are fine. We'll see). I'll check with clang master, if it fails there, you'd need to change the code indeed, but let's hope not. |
@davidrohr seems to me that error is not related to this pr. Should I fix it here? Not a problem to me. |
Ah, that is my standalone benchmark, which can be compiled after I updated the GPU CI container. |
Also replaces the inclusion in DCAfitterN.h