Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EMCAL-614] Fixing the pileup simulation #5426

Merged
merged 1 commit into from Feb 9, 2021
Merged

[EMCAL-614] Fixing the pileup simulation #5426

merged 1 commit into from Feb 9, 2021

Conversation

hahassan7
Copy link
Contributor

@hahassan7 hahassan7 commented Feb 9, 2021 •
edited

The problem with the pileup simulation has been fixed. Now the digitizer can process several digits from different collisions in one interaction record.

BCvsOrbit1024_1

mfasDa
mfasDa approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@mfasDa mfasDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial fix! Issue was that the livetime was calculated with respect to 0, not with respect to the trigger time, therefore each event created a new trigger.

shahor02
shahor02 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will merge once 1 CI has passed. The problem of trailers still remains...

@mfasDa
Copy link
Collaborator

mfasDa commented Feb 9, 2021

@shahor02 Thanks! The RCUtrailer will be attacked next. I assume the error from the macOS CI test is unrelated.

@shahor02 shahor02 merged commit 9f72140 into AliceO2Group:dev Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfasDa mfasDa mfasDa approved these changes

@shahor02 shahor02 shahor02 approved these changes

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hahassan7 @mfasDa @shahor02