Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply git clang-format to GPU. #5427

Merged
merged 1 commit into from Feb 10, 2021
Merged

Conversation

vkucera
Copy link
Collaborator

@vkucera vkucera commented Feb 9, 2021

Some unreasonable changes reverted.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 9, 2021

@davidrohr This time I ran git clang-format against the initial commit. It seems that the GitHub action applies different rules.

@davidrohr
Copy link
Collaborator

davidrohr commented Feb 9, 2021 via email

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 9, 2021

I see, thanks. I will try with Clang/latest then.

@davidrohr
Copy link
Collaborator

davidrohr commented Feb 9, 2021 via email

@davidrohr
Copy link
Collaborator

Btw, what you can also try to get a clean state: Apply git-clang-format first wrt to the very first commit of O2. Then apply it again only on the last formatting commit.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 10, 2021

Btw, what you can also try to get a clean state: Apply git-clang-format first wrt to the very first commit of O2. Then apply it again only on the last formatting commit.

I just tried that with clang-format version 11.0.0 which should be the version used by the GitHub action and there are still discrepancies.

@vkucera
Copy link
Collaborator Author

vkucera commented Feb 10, 2021

By the way, the URL from where one is supposed to download git-clang-format returns 403 Forbidden. I don't know if it might be a short-term or local issue though.

Some unreasonable changes reverted.
@vkucera vkucera marked this pull request as ready for review February 10, 2021 02:35
@davidrohr davidrohr merged commit 58f2995 into AliceO2Group:dev Feb 10, 2021
@vkucera vkucera deleted the clang-gpu branch February 18, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants