Reintroduce Wrapper Volume 0 for IB Layers of ITS3 Upgrade #5441
Conversation
|
Tagging @mconcas to follow this PR. |
|
|
||
| // Redefine Wrapper Volume 0 using information on IB radii | ||
| static constexpr float safety = 0.5; // Educated guess, may be improved | ||
| its->defineWrapperVolume(0, tdr5data[0][0] - safety, tdr5data[3][0] + safety, wrpZSpan[0]); |
There was a problem hiding this comment.
@mario6829 does not this repeat the volume for iw=0 in
AliceO2/Detectors/Upgrades/IT3/simulation/src/Detector.cxx
Lines 124 to 126 in 6032242
There was a problem hiding this comment.
Hi @shahor02
as the comment says, it is done on purpose because only at this stage of the code the IB radii are known (they are defined at lines 149-153). I preferred not to fix the wrapper radii but compute them from innermost and outermost IB cylinders in order to leave the possibility of changing the IB radii - in case this is needed for further studies - without running the risk of extrusions or worrying about changing other lines.
But if you think it is cleaner, I can define only wrappers 1 and 2 in lines 124-125, or I can move altogether the definition of all wrappers in lines 166-167. Please let me know your suggestions.
Many thanks. Cheers
Mario
There was a problem hiding this comment.
@mario6829 OK, sorry, I did not realize that this is only to book the parameters and the actual volume additions follows later.
|
Hi @mario6829 , thanks for the PR. (Don't mind my approval, I was just checking if the CODEOWNERSHIP works, as I have been put in the file. Sadly it does not @qgp ). |
|
|
||
| // Redefine Wrapper Volume 0 using information on IB radii | ||
| static constexpr float safety = 0.5; // Educated guess, may be improved | ||
| its->defineWrapperVolume(0, tdr5data[0][0] - safety, tdr5data[3][0] + safety, wrpZSpan[0]); |
There was a problem hiding this comment.
@mario6829 OK, sorry, I did not realize that this is only to book the parameters and the actual volume additions follows later.
|
failure unrelated |
To make the development of Upgraded ITS Inner Barrel simpler, the Wrapper Volume 0 holding the IB was removed. Since now new IB volumes are planned to be implemented, in order to keep well separated the IB and make the geometry tree cleaner, the Wrapper Volume 0 has been put back in place. Its radial extension is not fixed but based on the actual IB extension, so in case the radii of IB Layers are changed, the Wrapper Volume adapts automatically.
This modification is preparatory to the implementation of new ITS3 Inner Barrel elements for further studies.