The gen <=> reco mapping tests task #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Run 3 productions still needs the TrackExtensionTask being patched
victor-gonzalez
requested review from
iarsene,
jgrosseo,
ktf and
a team
as code owners
jgrosseo
reviewed
Sep 7, 2021
jgrosseo
reviewed
Sep 7, 2021
jgrosseo
reviewed
Sep 7, 2021
jgrosseo
reviewed
Sep 7, 2021
jgrosseo
reviewed
Sep 7, 2021
jgrosseo
reviewed
Sep 7, 2021
Also few cosmetic changes and removing the conversion to integer charge before counting generated particles
jgrosseo
reviewed
Sep 7, 2021
| @@ -1502,7 +1502,7 @@ struct CheckGeneratorLevelVsDetectorLevel { | |||
| for (auto& part : mcParticles) { | |||
| auto pdgpart = fPDG->GetParticle(part.pdgCode()); | |||
| if (pdgpart != nullptr) { | |||
| float charge = (pdgpart->Charge() / 3 >= 1) ? 1.0 : ((pdgpart->Charge() / 3 <= -1) ? -1.0 : 0.0); | |||
| float charge = (pdgpart->Charge() >= 3) ? 1.0 : ((pdgpart->Charge() <= -3) ? -1.0 : 0.0); | |||
There was a problem hiding this comment.
I merge it now, but these three lines I would have just written
if (pdgpart->Charge() != 0) {
ngen++
}
there will be no quarks I assume :)
There was a problem hiding this comment.
It will not be the first time I've found the quarks at generator level
Thanks anyway for the suggestion
And for the fixes!
jgrosseo
approved these changes
Sep 7, 2021
alibuild
pushed a commit
to alibuild/O2Physics
that referenced
this pull request
Jun 7, 2024
Please consider the following formatting changes to AliceO2Group#6380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Run 3 productions still needs the TrackExtensionTask being patched