[O2-2018] Allow usage of Microsoft GSL v2 and v3 #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barthelemy
approved these changes
Feb 11, 2021
|
@TimoWilken @ktf I don't understand why the o2 and o2-dataflow failed, but there are no errors and failed tests. Could you have a look please? |
|
@knopers8 it seems that the build succeeded, and then later failed without logs, so the "success" logs didn't get overwritten. I've found successful builds of this PR and commit for both red checks in the logs, so I've marked them as green. |
|
@TimoWilken Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See AliceO2Group/AliceO2#5424 for the rationale.
(but note that even without GSL changes' incentive, this PR actually only simplifies the code ;-) )