(fix) EAS issue with attachments in 2nd-level mailboxes (fixes #3505)

Alinto · Feb 11, 2016 · 11a2bcf · 11a2bcf
1 parent 0b1fbf0
commit 11a2bcf
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/ActiveSync/SOGoActiveSyncDispatcher.m b/ActiveSync/SOGoActiveSyncDispatcher.m
@@ -1147,17 +1147,18 @@ - (void) processGetAttachment: (id <DOMElement>) theDocumentElement
       SOGoMailAccounts *accountsFolder;
       SOGoUserFolder *userFolder;
       SOGoMailObject *mailObject;
+      NSMutableArray *a;
       NSArray *partKeys;
       int p;
 
-      NSRange r1, r2;
 
-      r1 = [realCollectionId rangeOfString: @"/"];
-      r2 = [realCollectionId rangeOfString: @"/"  options: 0  range: NSMakeRange(NSMaxRange(r1)+1, [realCollectionId length]-NSMaxRange(r1)-1)];
-
-      folderName = [realCollectionId substringToIndex: r1.location];
-      messageName = [realCollectionId substringWithRange: NSMakeRange(NSMaxRange(r1), r2.location-r1.location-1)];
-      pathToPart = [realCollectionId substringFromIndex: r2.location+1];
+      a = [[realCollectionId  componentsSeparatedByString: @"/"] mutableCopy];
+      [a autorelease]
+      pathToPart = [a lastObject];
+      [a removeLastObject];
+      messageName = [a lastObject];
+      [a removeLastObject];
+      folderName = [a componentsJoinedByString: @"/"];
 
       userFolder = [[context activeUser] homeFolderInContext: context];
       accountsFolder = [userFolder lookupName: @"Mail"  inContext: context  acquire: NO];
@@ -1354,20 +1355,21 @@ - (void) processItemOperations: (id <DOMElement>) theDocumentElement
               SOGoMailAccounts *accountsFolder;
               SOGoUserFolder *userFolder;
               SOGoMailObject *mailObject;
+              NSMutableArray *a;
 
               if ([fileReference length])
                 {
                   // fetch attachment
-                  NSRange r1, r2;
                   NSArray *partKeys;
                   int p;
 
-                  r1 = [realCollectionId rangeOfString: @"/"];
-                  r2 = [realCollectionId rangeOfString: @"/"  options: 0  range: NSMakeRange(NSMaxRange(r1)+1, [realCollectionId length]-NSMaxRange(r1)-1)];
-
-                  folderName = [realCollectionId substringToIndex: r1.location];
-                  messageName = [realCollectionId substringWithRange: NSMakeRange(NSMaxRange(r1), r2.location-r1.location-1)];
-                  pathToPart = [realCollectionId substringFromIndex: r2.location+1];
+                  a = [[realCollectionId  componentsSeparatedByString: @"/"] mutableCopy];
+                  [a autorelease]
+                    pathToPart = [a lastObject];
+                  [a removeLastObject];
+                  messageName = [a lastObject];
+                  [a removeLastObject];
+                  folderName = [a componentsJoinedByString: @"/"]; 
 
                   userFolder = [[context activeUser] homeFolderInContext: context];
                   accountsFolder = [userFolder lookupName: @"Mail"  inContext: context  acquire: NO];
@@ -1383,13 +1385,13 @@ - (void) processItemOperations: (id <DOMElement>) theDocumentElement
 
                   currentBodyPart = [mailObject lookupImap4BodyPartKey: [partKeys objectAtIndex:0]  inContext: context];
                   for (p = 1; p < [partKeys count]; p++)
-                  {
-                    currentBodyPart = [currentBodyPart lookupImap4BodyPartKey: [partKeys objectAtIndex:p]  inContext: context];
-                  }
+                    {
+                      currentBodyPart = [currentBodyPart lookupImap4BodyPartKey: [partKeys objectAtIndex:p]  inContext: context];
+                    }
 
                   [s appendString: @"<Fetch>"];
                   [s appendString: @"<Status>1</Status>"];
-                  [s appendFormat: @"<FileReference xmlns=\"AirSyncBase:\">%@</FileReference>", fileReference];
+                  [s appendFormat: @"<FileReference xmlns=\"AirSyncBase:\">mail/%@/%@/%@</FileReference>", [folderName stringByEscapingURL], messageName, pathToPart];
                   [s appendString: @"<Properties>"];
 
                   [s appendFormat: @"<ContentType xmlns=\"AirSyncBase:\">%@/%@</ContentType>", [[currentBodyPart partInfo] objectForKey: @"type"], [[currentBodyPart partInfo] objectForKey: @"subtype"]];