feat(core): Peer verification on TLS connections #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-nic
changed the title
the-nic
force-pushed
the
bugfix/5019-tls-hostname
branch
from
4e77614
to
1c05d4a
Compare
10 tasks
|
I'll have a look at it this week. Thanks! |
extrafu
reviewed
Jun 12, 2020
To improve TLS handshake performance, disable Nagle algorithm on the underlying socket.
Load system default CA trust store and verify the hostname of the endpoint. Simplify the SSL setup by reducing duplicate initialization code. Require a host name argument now to be able to compare the host names with. Fixes #5019
Implement peer verification for TLS connections also for GnuTLS. It will load the default system CA root store, and also send the Server Name Indication (SNI). Fixes #5019
the-nic
force-pushed
the
bugfix/5019-tls-hostname
branch
from
1c05d4a
to
bc766e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, the peer certificates in TLS connections have not been verified after establishing the connection to the host. This is not very good practice, as it allows for man in the middle attacks even if the connection is being established.
Therefore, extend NGActiveSSLSocket to enable peer verification for OpenSSL and GnuTLS.
Both will reuse the default CA root trust store in order to verify the certificate.
As an addition, also send Server Name indications to the peer which allows the server we are connecting to to choose the right certificate.
Fixes #5019