Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_mailto_links config option #356

Merged
merged 3 commits into from Jun 13, 2021

Conversation

gpanders
Copy link
Contributor

This is useful when converting HTML emails to text. Generally,
there's no reason to preserve these links when sending email.

This is useful when converting HTML emails to text. Generally,
there's no reason to preserve these links when sending email.
@coveralls
Copy link

coveralls commented Apr 19, 2021

Coverage Status

Coverage increased (+0.01%) to 97.075% when pulling 936e8eb on gpanders:ignore-mailto-links into e3ea63c on Alir3z4:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.824% when pulling 28945e6 on gpanders:ignore-mailto-links into 4592133 on Alir3z4:master.

@Alir3z4
Copy link
Owner

Alir3z4 commented Jun 12, 2021

I checked by sending plain/text email and opened the same email in Gmail and Thunderbird and also Windows Mail. Even though the email was plain text, they would make it clickable by doing mailto:xxx

Considering the above, would there be still a reason to remove them before sending?

@gpanders
Copy link
Contributor Author

Considering the above, would there be still a reason to remove them before sending?

I use html2text in my mail client to convert HTML emails into plain text so that I can then respond to them in plain text. There is no reason to linkify email addresses in a plain text email. Consider:

Please email me at [greg@example.com](mailto:greg@example.com).

So the ability to strip these out is useful for those of us who send and receive emails in plain text.

@Alir3z4
Copy link
Owner

Alir3z4 commented Jun 12, 2021

Yeah, makes sense.
Let me fix the conflict and get it merged.

@Alir3z4 Alir3z4 merged commit 2ee4495 into Alir3z4:master Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants