Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO Rev Bug - Slig walks into the left wall instead of going to the next screen to the right #1059

Closed
mouzedrift opened this issue Jan 23, 2021 · 1 comment
Labels
AO rev bug Something isn't working in AO

Comments

@mouzedrift
Copy link
Member

Steps to repro:

  • load the save
  • check the video for further instructions 馃憖
j2zZNpLAuf.mp4

save:
!.zip

function: SligSpawner::VUpdate_4028A0

@mouzedrift mouzedrift added the AO rev bug Something isn't working in AO label Jan 23, 2021
@MrSapps MrSapps added this to Reimpl bug in relive project Jan 23, 2021
@MrSapps
Copy link
Contributor

MrSapps commented Jan 26, 2021

This is an OG issue caused by using random initialized memory in Slig::field_13C_zone_rect in newer memory allocators sometimes these values for the rect x and w members are zero or near zero which makes

 if (IsFacingEffectiveLeft_46BD70(this) && (field_A8_xpos - (ScaleToGridSize_41FA30(field_BC_sprite_scale) * FP_FromInteger(2))) <= FP_FromInteger(field_13C_zone_rect.x))

not get hit in void Slig::WaitOrWalk_46E440()

Best we can do is hack the values of field_13C_zone_rect to something that works for this slig in the case where x/w are not set in void Slig::Init_46B890() and raise an OG bug to fix the map not having a left/right bound object for this spawned slig.

MrSapps pushed a commit that referenced this issue Jan 31, 2021
@MrSapps MrSapps removed this from Reimpl bug in relive project Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AO rev bug Something isn't working in AO
Projects
None yet
Development

No branches or pull requests

2 participants