Updating to latest openshift/api and go 1.16. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@menglingwei @xiaobing.meng Would you mind reviewing this? This bumps the openshift/api dependencies as well as moving to go-lang 1.16. |
|
@JoelSpeed PTAL |
JoelSpeed
reviewed
Sep 21, 2021
kwoodson
force-pushed
the
update_api
branch
from
a3e82cc
to
e07583f
Compare
kwoodson
commented
Sep 21, 2021
| WORKDIR /go/src/sigs.k8s.io/cluster-api-provider-alibabacloud | ||
| COPY . . | ||
| # VERSION env gets set in the openshift/release image and refers to the golang version, which interfers with our own | ||
| RUN unset VERSION \ | ||
| && GOPROXY=off NO_DOCKER=1 make build | ||
|
|
||
| FROM registry.ci.openshift.org/ocp/4.8:base | ||
| FROM registry.ci.openshift.org/ocp/4.10:base |
There was a problem hiding this comment.
@JoelSpeed I also bumped this to 4.10. I was able to build successfully.
podman build -f Dockerfile.rhel
[1/2] STEP 1/4: FROM registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.16-openshift-4.10 AS builder
[1/2] STEP 2/4: WORKDIR /go/src/sigs.k8s.io/cluster-api-provider-alibabacloud
--> Using cache 3f8d785debff9b32f5f1e7f11f0adc9d8de837976239f754d52a16e2a3507aca
--> 3f8d785debf
[1/2] STEP 3/4: COPY . .
--> d30e78cbc4f
[1/2] STEP 4/4: RUN unset VERSION && GOPROXY=off NO_DOCKER=1 make build
fatal: No tags can describe 'a3e82cc7c110ba648ecf2cb47b0b3c17b2302816'.
Try --always, or create some tags.
fatal: No tags can describe 'a3e82cc7c110ba648ecf2cb47b0b3c17b2302816'.
Try --always, or create some tags.
CGO_ENABLED=0 go build -o "bin/machine-controller-manager" \
-ldflags "-X github.com/AliyunContainerService/cluster-api-provider-alibabacloud/pkg/version.Raw= -extldflags "-static"" "github.com/AliyunContainerService/cluster-api-provider-alibabacloud/cmd/manager"
--> ec075e15a01
[2/2] STEP 1/2: FROM registry.ci.openshift.org/ocp/4.10:base
[2/2] STEP 2/2: COPY --from=builder /go/src/sigs.k8s.io/cluster-api-provider-alibabacloud/bin/machine-controller-manager /
[2/2] COMMIT
--> 77d2785aadd
77d2785aadd9fa24d8f61381bf1cad4b143bef54cdb5366fd0582c7ecbd72645
|
@menglingwei Can we get this merged please? |
Sorry, 9.19-9.21 I'm on a national holiday. Now i'm going to do it |
DONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the openshift/api as well as go-lang 1.16.