-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't get Private IP for machine address #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix manager run error
new file: pkg/actuators/machineset/controller_suite_test.go new file: pkg/actuators/machineset/controller_test.go new file: pkg/actuators/machineset/ec2_instance_types.go
modified: pkg/actuators/machineset/controller.go new file: pkg/apis/alicloudprovider/v1beta1/alibabacloudproviderconfig_types.go new file: pkg/apis/alicloudprovider/v1beta1/alibabacloudproviderstatus_types.go new file: pkg/apis/alicloudprovider/v1beta1/doc.go new file: pkg/apis/alicloudprovider/v1beta1/register.go new file: pkg/apis/alicloudprovider/v1beta1/zz_generated.deepcopy.go
new file: pkg/actuators/machineset/controller_suite_test.go new file: pkg/actuators/machineset/controller_test.go new file: pkg/actuators/machineset/ec2_instance_types.go
Staging Merge See merge request openshift/cluster-api-provider-alibabacloud!1
# Conflicts: # pkg/actuators/machineset/ecs_instance_types.go
Add instanceType ecs.g6, ecs.g6e, ecs.g5 See merge request openshift/cluster-api-provider-alibabacloud!2
Add gitlib-ci file See merge request openshift/cluster-api-provider-alibabacloud!3
Master See merge request openshift/cluster-api-provider-alibabacloud!4
remove v1alpha1 See merge request openshift/cluster-api-provider-alibabacloud!5
Add modifyInstanceChargeType for delete instance of PrePaid
Add g6a and c6a See merge request openshift/cluster-api-provider-alibabacloud!6
创建主机后按照AWS默认格式修改主机名 See merge request openshift/cluster-api-provider-alibabacloud!8
add tool code See merge request openshift/cluster-api-provider-alibabacloud!10
Change hostname format for more compatibles See merge request openshift/cluster-api-provider-alibabacloud!12
fix hostname See merge request openshift/cluster-api-provider-alibabacloud!13
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change InnerIpAddress to PrivateIpAddress