Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GiB as default unit instead of MiB #3

Merged
merged 13 commits into from Mar 1, 2019

Conversation

cheyang
Copy link
Collaborator

@cheyang cheyang commented Feb 23, 2019

No description provided.

Copy link
Contributor

@wsxiaozhang wsxiaozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use "unit" to replace all "metric" in wordings.
and it'd be safer to suppose each nvidia card has less than 100G memory, when decide the number getting from nvidia-smi is in GiB or MiB

@cheyang cheyang changed the title use GiB as default metric instead of MiB use GiB as default unit instead of MiB Feb 26, 2019
@wsxiaozhang wsxiaozhang merged commit 8adf448 into AliyunContainerService:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants