bugfix: modify volume usage #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allencloud
reviewed
Nov 21, 2017
cli/volume.go
Outdated
| @@ -157,7 +157,7 @@ func (v *VolumeRemoveCommand) Init(c *Cli) { | |||
| v.cli = c | |||
|
|
|||
| v.cmd = &cobra.Command{ | |||
| Use: "remove [volume]", | |||
| Use: "remove <volume name>", | |||
| Aliases: []string{"rm"}, | |||
| Short: "Remove pouch volumes", | |||
| Args: cobra.MinimumNArgs(1), | |||
There was a problem hiding this comment.
I think we need to more careful with the command args. And consistent with Use and Args.
You said Remove pouch volumes, does this support removing multi volumes?
If that the args cobra.MinimumNArgs(1) is correct, otherwise inconsistency happens.
There was a problem hiding this comment.
We should support removing multi volumes, just now not support.
There was a problem hiding this comment.
Updated, PTAL @allencloud
Modify volume usage. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
|
LGTM |
pouchrobot
added
the
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Describe what this PR did
Modify volume usage.
2.Does this pull request fix one issue?
fixes #128
fixes #129
3.Describe how you did it
4.Describe how to verify it
5.Special notes for reviews
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com