feature: add "pouch exec" #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feel so good to read such excellent code. Reviewing... |
allencloud
reviewed
Nov 24, 2017
cli/exec.go
Outdated
| func (e *ExecCommand) Init(c *Cli) { | ||
| e.cli = c | ||
| e.cmd = &cobra.Command{ | ||
| Use: "exec", |
There was a problem hiding this comment.
Could you add more details about the command usage, like @Letty5411 mentioned in PR #129, https://stackoverflow.com/questions/9725675/is-there-a-standard-format-for-command-line-shell-help-text
usage: app_name [options] required_input required_input2
options:
-a, --argument Does something
-b required Does something with "required"
-c, --command required Something else
-d [optlistitem1 optlistitem 2 ... ] Something with list
"exec" is used to execute a new process in container. You can execute a background process or a interactive process(e.g. bash) Signed-off-by: skoo87 <marckywu@gmail.com>
|
Updated, Now the help info: Flags: the format of "pouch exec [container] [flags] " is generated automatically by cobra, seems unable to control it. @allencloud |
|
LGTM |
pouchrobot
added
the
LGTM
This was referenced Nov 27, 2017
This was referenced Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"exec" is used to execute a new process in container. You can execute a
background process or a interactive process(e.g. bash)
usage:
./pouch exec -ti 12345 /bin/sh
./pouch exec 12345 "/bin/echo hello" , there is quotation mark.
Signed-off-by: skoo87 marckywu@gmail.com