bugfix: deb package build failed #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we remove the ceph volume modules, the deb package building failed. We will remove the ceph dependency in Makefile Signed-off-by: Eric Li <lcy041536@gmail.com>
|
LGTM and it works well for me. |
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
==========================================
- Coverage 41.29% 41.26% -0.03%
==========================================
Files 274 274
Lines 18123 18123
==========================================
- Hits 7483 7478 -5
- Misses 9728 9733 +5
Partials 912 912
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we remove the ceph volume modules, the deb package building failed.
We will remove the ceph dependency in Makefile
Signed-off-by: Eric Li lcy041536@gmail.com
Ⅰ. Describe what this PR did
As we remove the ceph volume modules, the deb package building failed. We will remove the ceph dependency in Makefile
Ⅱ. Does this pull request fix one issue?
fixes #1726
Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews