Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add pouchd -v command #197

Merged

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

1.Describe what this PR did
Sometimes users need to check pouchd's version without pouch client, especially on those scenarios that we cannot send socket/HTTP request.

Add pouchd --version or pouchd -v to pouchd command line.

2.Does this pull request fix one issue?

fixes #43

3.Describe how you did it
Add a flag there

4.Describe how to verify it

root@ubuntu:~/go/src/github.com/alibaba/pouch# pouchd --version
0.1.0-dev
root@ubuntu:~/go/src/github.com/alibaba/pouch# pouchd -v
0.1.0-dev

5.Special notes for reviews
NONE

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@skoowoo
Copy link
Contributor

skoowoo commented Dec 1, 2017

LGTM

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Dec 1, 2017
@skoowoo skoowoo merged commit c2c5be6 into AliyunContainerService:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] support pouchd --version command line
3 participants