Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri support to update pids limit by annotation #2791

Conversation

wangforthinker
Copy link
Contributor

Signed-off-by: allen.wang allen.wq@alipay.com

Ⅰ. Describe what this PR did

CRI support to set pids limit by annotation in action of create and update .

Ⅱ. Does this pull request fix one issue?

none.

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

add unit test.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #2791 into master will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2791     +/-   ##
=========================================
+ Coverage   69.27%   69.37%   +0.1%     
=========================================
  Files         277      277             
  Lines       17313    17321      +8     
=========================================
+ Hits        11994    12017     +23     
+ Misses       3976     3967      -9     
+ Partials     1343     1337      -6
Flag Coverage Δ
#criv1alpha2_test 39.3% <0%> (-0.09%) ⬇️
#integration_test_0 36.53% <0%> (ø) ⬆️
#integration_test_1 35.31% <0%> (-0.05%) ⬇️
#integration_test_2 36.35% <0%> (-0.05%) ⬇️
#integration_test_3 35.43% <0%> (ø) ⬆️
#node_e2e_test 35.08% <0%> (+0.07%) ⬆️
#unittest 28.71% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
cri/v1alpha2/cri_utils.go 88.25% <100%> (+0.12%) ⬆️
ctrd/container.go 53.53% <0%> (-0.39%) ⬇️
cri/v1alpha2/cri.go 70.97% <0%> (+0.38%) ⬆️
daemon/mgr/container_utils.go 82.95% <0%> (+1.13%) ⬆️
pkg/meta/store.go 68.99% <0%> (+1.55%) ⬆️
ctrd/watch.go 77.46% <0%> (+5.63%) ⬆️
cri/ocicni/cni_manager.go 70.58% <0%> (+11.76%) ⬆️

@allencloud
Copy link
Collaborator

code-check fails, @wangforthinker

cri/v1alpha2/cri_utils_test.go:1::warning: file is not gofmted with -s (gofmt)
cri/v1alpha2/cri_utils_test.go:1::warning: file is not goimported (goimports)

Signed-off-by: allen.wang <allen.wq@alipay.com>
Copy link
Contributor

@zhuangqh zhuangqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allencloud
Copy link
Collaborator

Merging...

@allencloud allencloud merged commit d692da4 into AliyunContainerService:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants