bugfix: fix error to set volume options #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using pouch cli to run container, command is: ```bash # pouch run -d -v /tmp/test:/tmp/test:rslave,ro busybox top ``` it will parse `-v` become to bind ["/tmp/test:/tmp/test:rslave", "ro"] by default, `,` is separator of command, so we should refact the default rules. Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2798 +/- ##
==========================================
- Coverage 69.41% 69.34% -0.08%
==========================================
Files 277 278 +1
Lines 17321 17340 +19
==========================================
+ Hits 12024 12025 +1
- Misses 3967 3975 +8
- Partials 1330 1340 +10
|
|
Since this pr is cherry-pick from intenal branch, reviewed! LGTM |
pouchrobot
added
the
LGTM
fuweid
reviewed
Apr 10, 2019
| @@ -89,7 +90,8 @@ func addCommonFlags(flagSet *pflag.FlagSet) *container { | |||
|
|
|||
| flagSet.StringVar(&c.utsMode, "uts", "", "UTS namespace to use") | |||
|
|
|||
| flagSet.StringSliceVarP(&c.volume, "volume", "v", nil, "Bind mount volumes to container, format is: [source:]<destination>[:mode], [source] can be volume or host's path, <destination> is container's path, [mode] can be \"ro/rw/dr/rr/z/Z/nocopy/private/rprivate/slave/rslave/shared/rshared\"") | |||
| flagSet.VarP(config.NewVolumes(&c.volume), "volume", "v", "Bind mount volumes to container, format is: [source:]<destination>[:mode], [source] can be volume or host's path, <destination> is container's path, [mode] can be \"ro/rw/dr/rr/z/Z/nocopy/private/rprivate/slave/rslave/shared/rshared\"") | |||
| //flagSet.StringSliceVarP(&c.volume, "volume", "v", nil, "Bind mount volumes to container, format is: [source:]<destination>[:mode], [source] can be volume or host's path, <destination> is container's path, [mode] can be \"ro/rw/dr/rr/z/Z/nocopy/private/rprivate/slave/rslave/shared/rshared\"") | |||
There was a problem hiding this comment.
could we remove the comment line if we don't need it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using pouch cli to run container, command is:
# pouch run -d -v /tmp/test:/tmp/test:rslave,ro busybox topit will parse
-vbecome to bind ["/tmp/test:/tmp/test:rslave", "ro"]by default,
,is separator of command, so we should refact the defaultrules.
Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
none
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
added
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews