Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to upsteam #2990

Merged
merged 28 commits into from
Oct 22, 2019
Merged

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Oct 18, 2019

Ⅰ. Describe what this PR did

sync to upsteam

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com
Signed-off-by: zhijin zhijin.zqh@alibaba-inc.com
Signed-off-by: shenling.yyb shenling.yyb@alibaba-inc.com

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #2990 into master will decrease coverage by 1.39%.
The diff coverage is 47.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2990     +/-   ##
=========================================
- Coverage   68.12%   66.73%   -1.4%     
=========================================
  Files         291      291             
  Lines       18389    18655    +266     
=========================================
- Hits        12528    12449     -79     
- Misses       4405     4720    +315     
- Partials     1456     1486     +30
Flag Coverage Δ
#criv1alpha2_test 34.54% <26.35%> (-0.19%) ⬇️
#integration_test_0 36.41% <31.08%> (+0.31%) ⬆️
#integration_test_1 35.43% <32.26%> (-0.06%) ⬇️
#integration_test_2 36.36% <30.57%> (+0.27%) ⬆️
#integration_test_3 35.76% <29.64%> (+0.18%) ⬆️
#node_e2e_test ?
#unittest 26.69% <7.27%> (-1.19%) ⬇️
Impacted Files Coverage Δ
hookplugins/ContainerPlugin.go 100% <ø> (ø) ⬆️
hookplugins/APIPlugin.go 100% <ø> (ø) ⬆️
cri/metrics/metrics.go 100% <ø> (ø) ⬆️
storage/plugins/plugins.go 50% <ø> (ø) ⬆️
hookplugins/CriPlugin.go 100% <ø> (ø) ⬆️
hookplugins/VolumePlugin.go 100% <ø> (ø) ⬆️
cri/stream/httpstream/spdy/upgrade.go 54.28% <0%> (ø) ⬆️
cri/stream/remotecommand/httpstream.go 44.04% <0%> (-2.6%) ⬇️
daemon/logger/logbuffer/logbuff.go 0% <0%> (ø) ⬆️
daemon/mgr/system.go 75.37% <0%> (ø) ⬆️
... and 115 more

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @rudyfly
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @rudyfly
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/%!s(MISSING)/%!s(MISSING)/blob/master/CONTRIBUTING.md

rudyfly and others added 20 commits October 22, 2019 10:19
add resize exec window for pouch cli `pouch exec`

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
When containerd publishes more and more oom event during
container-delete action, the updateContainerState eventHook will put the
dead container info into local disk, which removed by container-delete
action. It is concurrent issue. Therefore, before we update container
status first, if it is dead(removing), we should skip it.
fix can not scan volume plugin
add --volume-driver for pouch command.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Signed-off-by: huaihuan.zy <huaihuan.zy@alibaba-inc.com>
Signed-off-by: huaihuan.zy <huaihuan.zy@alibaba-inc.com>
fix wrong way to set http timeout, and change timeout to 10 min.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
fix wrong way to prepare working directory, detail:
https://work.aone.alibaba-inc.com/issue/21989036

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Signed-off-by: huaihuan.zy <huaihuan.zy@alibaba-inc.com>
push should not try to fetch the manifest like pull, because the
repository is brand new one and doesn't exist.
…ainer rootfs is set to shared mount propagation,

bind mount may inherit rootfs mount propagation if bind mount propagation is "". This is not as expected.

Signed-off-by: allen.wang <allen.wq@alipay.com>
refact daemon log, and request id and container id.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
govendor fetch "github.com/cri-o/ocicni/pkg/ocicni::github.com/alibaba/ocicni/pkg/ocicni"

Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
1. container may be deleted using 'pouch rm'
thus, stop pod would fail and netns would leak.
this patch dismiss the container not found error
2. the existence of pod depends on sandbox metadata
not the metadata of pouch container

Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
zhijin and others added 8 commits October 22, 2019 10:19
Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
when project quota, use `chattr -R` to set quota id recursively.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
when starting or creating containers in
environments which has thousands of
lines in /proc/mounts

https://work.aone.alibaba-inc.com/issue/22582695
Signed-off-by: shenling.yyb <shenling.yyb@alibaba-inc.com>
Signed-off-by: zhijin <zhijin.zqh@alibaba-inc.com>
@pouchrobot
Copy link
Collaborator

@rudyfly Thanks for your contribution. 🍻
Please sign off in each of your commits.

@zhuangqh
Copy link
Contributor

merging first, and I will submit another pr to fix the node e2e test

@zhuangqh zhuangqh merged commit 93cb0b1 into AliyunContainerService:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants