Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node e2e test #2991

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @zhuangqh
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #2991 into master will increase coverage by 1.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2991      +/-   ##
==========================================
+ Coverage   66.74%   67.99%   +1.25%     
==========================================
  Files         291      291              
  Lines       18655    18660       +5     
==========================================
+ Hits        12451    12688     +237     
+ Misses       4719     4488     -231     
+ Partials     1485     1484       -1
Flag Coverage Δ
#criv1alpha2_test 34.52% <91.66%> (+0.03%) ⬆️
#integration_test_0 36.4% <91.66%> (+0.02%) ⬆️
#integration_test_1 35.43% <91.66%> (-0.01%) ⬇️
#integration_test_2 36.47% <91.66%> (+0.11%) ⬆️
#integration_test_3 35.79% <91.66%> (-0.01%) ⬇️
#node_e2e_test 33.96% <100%> (?)
#unittest 26.68% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
daemon/mgr/container_utils.go 76.21% <100%> (+1.08%) ⬆️
daemon/logger/jsonfile/utils.go 71.54% <0%> (-1.63%) ⬇️
ctrd/image.go 69.11% <0%> (+0.73%) ⬆️
daemon/mgr/container.go 60.69% <0%> (+0.89%) ⬆️
daemon/mgr/spec_linux.go 79.26% <0%> (+1.33%) ⬆️
daemon/mgr/container_stats.go 71.66% <0%> (+2.22%) ⬆️
daemon/mgr/spec_mount.go 92.3% <0%> (+2.56%) ⬆️
cri/stream/remotecommand/httpstream.go 46.63% <0%> (+2.59%) ⬆️
daemon/logger/jsonfile/encode.go 81.52% <0%> (+3.26%) ⬆️
daemon/logger/crilog/log.go 81.94% <0%> (+5.55%) ⬆️
... and 6 more

@fuweid
Copy link
Contributor

fuweid commented Oct 24, 2019

ping @zhuangqh , I think we missing a patch here for nil panic issue. could you update the pr in time? Thanks

panic: interface conversion: interface {} is nil, not *mgr.Container
goroutine 12163 [running]:
github.com/alibaba/pouch/daemon/mgr.(*ContainerManager).container(0xc0003f9680, 0xc001166d00, 0x40, 0x40, 0x2254f60, 0x1)
  /home/travis/gopath/src/github.com/alibaba/pouch/daemon/mgr/container_utils.go:62 +0x2d9
github.com/alibaba/pouch/daemon/mgr.(*ContainerManager).Get(0xc0003f9680, 0x262e4a0, 0xc001bb18c0, 0xc001166d00, 0x40, 0xc0001205a0, 0x0, 0x0)
  /home/travis/gopath/src/github.com/alibaba/pouch/daemon/mgr/container.go:583 +0x6a
github.com/alibaba/pouch/cri/v1alpha2.(*CriManager).ListPodSandbox(0xc0004b1130, 0x262e4a0, 0xc001bb18c0, 0xc0004867f0, 0x0, 0x0, 0x0)
  /home/travis/gopath/src/github.com/alibaba/pouch/cri/v1alpha2/cri.go:697 +0x276
github.com/alibaba/pouch/cri/apis/v1alpha2._RuntimeService_ListPodSandbox_Handler.func1(0x262e4a0, 0xc001bb18c0, 0x223efa0, 0xc0004867f0, 0x23525e1, 0x14, 0x234359f, 0xa)
  /home/travis/gopath/src/github.com/alibaba/pouch/cri/apis/v1alpha2/api.pb.go:4678 +0x86
github.com/alibaba/pouch/pkg/grpc/interceptor.PayloadUnaryServerInterceptor.func1(0x262e4a0, 0xc001bb18c0, 0x223efa0, 0xc0004867f0, 0xc000b7e820, 0xc000b7e840, 0x2388aff, 0x1f, 0x2388b1f, 0xe)
  /home/travis/gopath/src/github

@pouchrobot pouchrobot added size/S and removed size/XS labels Oct 24, 2019
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants