Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add filter for flying request recorder #2999

Merged

Conversation

zhuangqh
Copy link
Contributor

Signed-off-by: zhuangqh zhuangqhc@gmail.com

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

add filter when graceful shutdown server

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2999 into master will decrease coverage by 1.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2999      +/-   ##
==========================================
- Coverage   67.41%   65.79%   -1.62%     
==========================================
  Files         291      291              
  Lines       18660    18666       +6     
==========================================
- Hits        12579    12282     -297     
- Misses       4572     4954     +382     
+ Partials     1509     1430      -79
Flag Coverage Δ
#criv1alpha2_test 34.53% <37.5%> (-0.12%) ⬇️
#integration_test_0 36.45% <100%> (+0.04%) ⬆️
#integration_test_1 ?
#integration_test_2 36.38% <100%> (+0.02%) ⬆️
#integration_test_3 35.84% <100%> (?)
#node_e2e_test 33.99% <37.5%> (-0.23%) ⬇️
#unittest 26.67% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
apis/server/router.go 91.66% <100%> (+0.28%) ⬆️
ctrd/image_commit.go 0% <0%> (-65%) ⬇️
daemon/mgr/container_commit.go 0% <0%> (-54.72%) ⬇️
daemon/mgr/container_copy.go 38.95% <0%> (-17.45%) ⬇️
apis/server/copy_bridge.go 46.93% <0%> (-16.33%) ⬇️
daemon/mgr/container_exec.go 64.78% <0%> (-14.79%) ⬇️
pkg/reference/def.go 77.77% <0%> (-11.12%) ⬇️
daemon/mgr/network_utils.go 30.43% <0%> (-10.87%) ⬇️
daemon/mgr/events.go 84.41% <0%> (-9.1%) ⬇️
apis/server/network_bridge.go 57.25% <0%> (-8.88%) ⬇️
... and 30 more

@zhuangqh zhuangqh requested a review from fuweid November 19, 2019 12:12
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 7cef384 into AliyunContainerService:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants