Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aliyun Mirror URL #3017

Merged
merged 1 commit into from
Jul 10, 2022
Merged

Update Aliyun Mirror URL #3017

merged 1 commit into from
Jul 10, 2022

Conversation

wxh06
Copy link
Contributor

@wxh06 wxh06 commented Jun 19, 2020

Ⅰ. Describe what this PR did

Replace http://mirrors.aliyun.com in INSTALLATION.md with https://mirrors.aliyun.com to install PouchContainer from mirrors.aliyun.com via HTTPS.
INSTALLATION.md 中的 http://mirrors.aliyun.com 替换为 https://mirrors.aliyun.com,以通过 HTTPS 从 mirrors.aliyun.com 安装 PouchContainer。

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2020

CLA assistant check
All committers have signed the CLA.

@rudyfly rudyfly requested a review from cxz66666 July 7, 2022 11:44
@cxz66666
Copy link
Collaborator

Seem that this url is changed witch http://mirrors.aliyun.com/opsx/pouch/linux/debian.orig/ , could you help to update it? After your response, I will review and merge it ASAP!

INSTALLATION.md Outdated Show resolved Hide resolved
@wxh06 wxh06 requested a review from cxz66666 July 10, 2022 03:31
Copy link
Collaborator

@cxz66666 cxz66666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you can squash these commits! Thank you for your contribution!

INSTALLATION.md Outdated Show resolved Hide resolved
@wxh06 wxh06 changed the title Access mirrors.aliyun.com via HTTPS instead of HTTP Update Aliyun Mirror URL Jul 10, 2022
@wxh06
Copy link
Contributor Author

wxh06 commented Jul 10, 2022

Hope you can squash these commits!

I amended the last commit.
Is it necessary to squash 58b8605 and 10997fc?

@cxz66666
Copy link
Collaborator

Hope you can squash these commits!

I amended the last commit. Is it necessary to squash 58b8605 and 10997fc?

Yes, I think it's needed! 😄

@wxh06 wxh06 requested a review from cxz66666 July 10, 2022 04:30
Copy link
Collaborator

@cxz66666 cxz66666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cxz66666 cxz66666 merged commit 39ebc83 into AliyunContainerService:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants