feat: support kill command #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
In fact, we consider carefully about add a kill command for pouch, and finally we think it's a good idea, because much time when we want to stop a container immediately, we can use kill command instead of stop command(which have default timeout 10s). On the other hand, docker already support kill command!
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact, we consider carefully about add a kill command for pouch, and finally we think it's a good idea, because much time when we want to stop a container immediately, we can use kill command instead of stop command(which have default timeout 10s).
On the other hand, docker already support kill command!
Ⅰ. Describe what this PR did
Add kill command to pouch.
Ⅱ. Does this pull request fix one issue?
fixes #2917
similar as #2924 (but server design is much different)
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Add unit test and integration test
Ⅳ. Describe how to verify it
just use
pouch kill --helpto see the helper!Ⅴ. Special notes for reviews
Note that maybe it also need update some docs about this new command, I already use
pouch gen-docto update it and update swagger.yml manually, but I don't know how to updatedocs/api/HTTP_API.mdandapi/types(maybe also need update other files), anyone can point out it ? 😢