Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Volume Inspect API in daemon side #498

Merged
merged 1 commit into from Jan 4, 2018

Conversation

allencloud
Copy link
Collaborator

Signed-off-by: Allen Sun allensun.shl@alibaba-inc.com

1.Describe what this PR did

This PR adds two API endpoints in swagger.yml:

  • GET /volumes/{id}
  • DELETE /volumes/{id}

And the second API implementation has been done in code base.

This PR also adds GET /volumes/{id} in the daemon side.

2.Does this pull request fix one issue?
NONE

3.Describe how you did it
NONE

4.Describe how to verify it
NONE

5.Special notes for reviews
NONE

@codecov-io
Copy link

codecov-io commented Jan 4, 2018

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   18.28%   18.28%           
=======================================
  Files          34       34           
  Lines        1766     1766           
=======================================
  Hits          323      323           
  Misses       1408     1408           
  Partials       35       35
Impacted Files Coverage Δ
daemon/mgr/container.go 4.13% <0%> (ø) ⬆️
daemon/mgr/volume.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2091fda...8e3ed79. Read the comment docs.

Signed-off-by: Allen Sun <allensun.shl@alibaba-inc.com>
@Letty5411
Copy link
Contributor

LGTM

@Letty5411 Letty5411 merged commit c21b3e7 into AliyunContainerService:master Jan 4, 2018
@allencloud allencloud deleted the add-volume-get branch January 4, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants