Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add volume list command #578

Merged
merged 1 commit into from Jan 22, 2018

Conversation

rudyfly
Copy link
Collaborator

@rudyfly rudyfly commented Jan 15, 2018

1.Describe what this PR did
Add volume list command, it returns all the volumes in pouch.
Now it just returns the name of volume.

2.Does this pull request fix one issue?

NONE

3.Describe how you did it

4.Describe how to verify it
create three volume in pouchd

# pouch volume create -d local -n pouch-volume-1 -o size=100g
CreatedAt:
Driver:       local
Mountpoint:
Name:         pouch-volume-1
Scope:
# pouch volume create -d local -n pouch-volume-2 -o size=100g
Driver:       local
Mountpoint:
Name:         pouch-volume-2
Scope:
CreatedAt:
# pouch volume create -d local -n pouch-volume-3 -o size=100g
Scope:
CreatedAt:
Driver:       local
Mountpoint:
Name:         pouch-volume-3

then use list to get the volumes that are created just now.

# pouch volume list
Name:
pouch-volume-1
pouch-volume-2
pouch-volume-3

5.Special notes for reviews

Signed-off-by: Rudy Zhang rudyflyzhang@gmail.com

@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #578 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   13.58%   13.43%   -0.15%     
==========================================
  Files          65       65              
  Lines        3541     3579      +38     
==========================================
  Hits          481      481              
- Misses       3010     3048      +38     
  Partials       50       50
Impacted Files Coverage Δ
client/volume.go 0% <0%> (ø) ⬆️
cli/volume.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d28bc3...c5ee686. Read the comment docs.

@allencloud
Copy link
Collaborator

Could you add some integration test including API test case and cli test case? @rudyfly

@rudyfly
Copy link
Collaborator Author

rudyfly commented Jan 16, 2018

@allencloud @Letty5411 How to add integration test,can you give me an example?

@allencloud
Copy link
Collaborator

Yes, you can take a look at file test/api_volume_create_test.go and test/cli_volume_test.go.

The previous one is focused on API integration test and the latter one is cli integration test. @rudyfly

Add volume list command, it returns all the volumes in pouch.
Now it just returns the name of volume.

Signed-off-by: Rudy Zhang <rudyflyzhang@gmail.com>
@rudyfly
Copy link
Collaborator Author

rudyfly commented Jan 19, 2018

@allencloud @Letty5411 PTAL.

@allencloud
Copy link
Collaborator

LGTM, while I would like to invite @Letty5411 to double check this.

@pouchrobot pouchrobot added the LGTM one maintainer or community participant agrees to merge the pull reuqest. label Jan 19, 2018
@allencloud allencloud added this to Volume in Pouch-v0.2 Jan 19, 2018
@Letty5411
Copy link
Contributor

LGTM

@Letty5411 Letty5411 merged commit 50a7d1e into AliyunContainerService:master Jan 22, 2018
@allencloud allencloud moved this from Volume to done in Pouch-v0.2 Jan 23, 2018
@rudyfly rudyfly deleted the volume_list branch October 29, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/cli areas/storage kind/feature LGTM one maintainer or community participant agrees to merge the pull reuqest. size/XL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants