feature: build rpm package for pouch #597
Conversation
|
Thanks a lot for your work, @zzchun |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 13.58% 13.58%
=======================================
Files 65 65
Lines 3541 3541
=======================================
Hits 481 481
Misses 3010 3010
Partials 50 50Continue to review full report at Codecov.
|
| # kill only the pouch process, not all processes in the cgroup | ||
| KillMode=process | ||
|
|
||
| # restart the docker process if it exits prematurely |
| LimitCORE=infinity | ||
|
|
||
| TimeoutStartSec=0 | ||
| # set delegate yes so that systemd does not reset the cgroups of docker containers |
|
@zzchun It would be better that there is a doc with this PR |
| # docker run -it -v /root/rpm/:/root/rpm pouch:rpm bash -c hack/package/build.sh | ||
| # | ||
| # 4. In this example rpm package will be output in '/root/rpm/package/' directory | ||
|
|
There was a problem hiding this comment.
Maybe also copy this to a build.doc?
There was a problem hiding this comment.
I'll write a doc after building deb package
hack/package/build.sh
Outdated
| PACKAGEDIR=/root/rpm/package | ||
|
|
||
| # the branch to build pouch | ||
| POUCH_BRANCH='0.1.x' |
There was a problem hiding this comment.
Do we need to change this variable to be : POUCH_BRANCH={$POUCH_BRANCH:?"Must specify pouch branch"} ? the same for VERSION
There was a problem hiding this comment.
Good idea，I‘ll parse these parameters via env
hack/package/build.sh
Outdated
| SCRIPTSDIR=$DIR/package/rpm/scripts | ||
|
|
||
| POUCHDIR=$TMP/source | ||
| mkdir $POUCHDIR |
There was a problem hiding this comment.
could add a rm option after each mkdir, for example
trap "rm -rf $POUCHDIR" EXIT
hack/package/build.sh
Outdated
| { | ||
| mkdir -p $LXC_DIR && pushd $LXC_DIR | ||
| git clone https://github.com/lxc/lxcfs.git | ||
| cd lxcfs && git checkout -q $LXC_TAG |
Signed-off-by: Zhanchun Zhang <zzchun@zju.edu.cn>
|
How about adding a config.tmpl, so that user could get there own configure file by modifying it ? |
|
I will give an example in the build doc. |
|
@zzchun No problem, I'll merge it. |
Signed-off-by: Zhanchun Zhang zzchun@zju.edu.cn
1.Describe what this PR did
This pr added a way to build rpm package
2.Does this pull request fix one issue?
fixes part of #67
3.Describe how you did it
Build pouch:rpm image
cd hack/package/rpm
docker build -t pouch:rpm .
Mount a directory which contains gpg keys, eg
$ tree rpm/keys/
rpm/keys/
├── gpg
└── secretkey
Run the following command, and enter your pass phrase to sign rpm package
docker run -it -v /root/rpm/:/root/rpm pouch:rpm bash -c hack/package/build.sh
In this example rpm package will be output in '/root/rpm/package/' directory
4.Describe how to verify it
5.Special notes for reviews